Results 163 comments of jrhee17

> However, I will modify it to ensure backwards compatibility as you advised and consider a better way as another issue. Thanks! Let us know if you would like to...

The build seems to be failing. Is this PR ready for review?

> should I make and work on a separate issue ticket or fix it together in this PR? It's your choice, but I prefer that it be handled separately

> However, this just raises a ResponseTimeoutException... Am I missing something necessary in the Http1ResponseDecoder? Do you have any ideas? https://github.com/line/armeria/pull/5646#discussion_r1588860191 Like pointed out in this comment, the `readLine()` is...

I originally also thought of an approach similar to @ikhoon 's idea mainly due to the ease of implementation. > Do you think it's acceptable not to inject CORS headers...

> Let's remove Nullable in the ListenerResourceNode constructor. Coincidentally, due to the recent changes now `ListenerRoot` can pass a `null` config source https://github.com/line/armeria/blob/42edbb2940a0447f8df9dd189fe24acfc842335a/xds/src/main/java/com/linecorp/armeria/xds/ListenerRoot.java#L37

Sorry about the late check. Thanks @Dogacel and @ikhoon ! 🙇 👍 🙇

I've added a small commit which - Deprecates `ServerBuilder#virtualHost` methods that doesn't support `VirtualHostBuilder` reuse - Adds a `ServerBuilder#withVirtualHost` which supports `VirtualHostBuilder` reuse - Deprecates `VirtualHostBuilder#hostnamePattern` which makes `VirtualHostBuilder` reuse...

We probably need to check how many occurrences there are, but I would feel better if this was fixed on the IDE level in terms of maintainability