armeria
armeria copied to clipboard
Add a periodic check for cacheable task misses
Motivation:
It is difficult to track if our gradle scripts are caching tasks correctly. It has been suggested that we can periodically run validation scripts to verify this behavior. Note that the contents of this PR closely follows the guide at: https://github.com/gradle/gradle-enterprise-build-validation-scripts/blob/main/Gradle.md
ref: https://github.com/jrhee17/armeria/actions/runs/6091624488
Modifications:
- Added an actions job which runs build periodically and fails if the validation is incorrect.
- Also added cleanup jobs since the build result may become large
Result:
- Automated gradle script caching miss detection
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 74.22%. Comparing base (
b8eb810
) to head (414c481
). Report is 149 commits behind head on main.
:exclamation: Current head 414c481 differs from pull request most recent head a5836ba. Consider uploading reports for the commit a5836ba to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## main #5172 +/- ##
============================================
+ Coverage 73.95% 74.22% +0.26%
+ Complexity 20115 19856 -259
============================================
Files 1730 1701 -29
Lines 74161 73158 -1003
Branches 9465 9356 -109
============================================
- Hits 54847 54302 -545
+ Misses 14837 14424 -413
+ Partials 4477 4432 -45
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🔍 Build Scan® (commit: a5836bac48ebd7d6c80b2f6ec7103b5a3710f4dd)
Job name | Status | Build Scan® |
---|---|---|
build-windows-latest-jdk-19 | ✅ | https://ge.armeria.dev/s/kmlrl2aphfzve |
build-self-hosted-unsafe-jdk-8 | ✅ | https://ge.armeria.dev/s/emsxd4mpjhswi |
build-self-hosted-unsafe-jdk-19-snapshot-blockhound | ✅ | https://ge.armeria.dev/s/il6ujzrevdsi4 |
build-self-hosted-unsafe-jdk-17-min-java-17-coverage | ✅ | https://ge.armeria.dev/s/o4tyyhynzp5o2 |
build-self-hosted-unsafe-jdk-17-min-java-11 | ✅ | https://ge.armeria.dev/s/ephs5g2d3ug3g |
build-self-hosted-unsafe-jdk-17-leak | ✅ | https://ge.armeria.dev/s/5en7ix3wstioy |
build-self-hosted-unsafe-jdk-11 | ✅ | https://ge.armeria.dev/s/wmnhgfmlwoeyi |
build-macos-12-jdk-19 | ✅ | https://ge.armeria.dev/s/pulrwc2fvsags |
As discussed on the call, we also have composite github action for build validation scripts (sorry that I forgot to tell you about it beforehand).
Here are the instructions on how to use it: https://github.com/gradle/gradle-enterprise-build-validation-scripts/tree/main/.github/actions/gradle And you can see how it's used and what a run with that looks like here: https://github.com/gradle/gradle-enterprise-oss-projects/actions/runs/5990004374
Note: confirmed the new changeset via https://github.com/jrhee17/armeria/actions/runs/6219845149/job/16878697488
Is there any reason that we are not running experiment 1 as well?
There is no impact on the build itself, let me go ahead and merge this