centraldogma
centraldogma copied to clipboard
Migrate `dependencies.yml` to `dependencies.toml`
Motivation:
Gradle's version catalogs provides concise and sophisticated version manangement.
Modifications:
- Switch
dependencies.yml
intodependencies.toml
- Migrate all
build.gradle
s to use new version catalogs API - Fix wrong dependency in
spring-boot{1}-autoconfigure
- Drop
spring-boot-starter
dependency and correctly depend onspring-boot-autoconfigure
- Drop
- Make
managedVersions
task generate a backward compatiblemanaged_versions.yml
file.
Result:
Better dependency manangement.
Codecov Report
Base: 70.42% // Head: 70.44% // Increases project coverage by +0.02%
:tada:
Coverage data is based on head (
884ba26
) compared to base (488de50
). Patch has no changes to coverable lines.
Additional details and impacted files
@@ Coverage Diff @@
## master #716 +/- ##
============================================
+ Coverage 70.42% 70.44% +0.02%
- Complexity 3422 3423 +1
============================================
Files 349 349
Lines 13474 13474
Branches 1454 1454
============================================
+ Hits 9489 9492 +3
+ Misses 3125 3123 -2
+ Partials 860 859 -1
Impacted Files | Coverage Δ | |
---|---|---|
.../com/linecorp/centraldogma/client/FileWatcher.java | 80.00% <0.00%> (-10.00%) |
:arrow_down: |
...al/storage/repository/cache/CachingRepository.java | 94.53% <0.00%> (-0.79%) |
:arrow_down: |
...server/internal/replication/EmbeddedZooKeeper.java | 78.28% <0.00%> (-0.66%) |
:arrow_down: |
...raldogma/server/internal/api/ContentServiceV1.java | 85.82% <0.00%> (+0.74%) |
:arrow_up: |
.../linecorp/centraldogma/client/AbstractWatcher.java | 88.66% <0.00%> (+1.33%) |
:arrow_up: |
...centraldogma/server/internal/api/WatchService.java | 79.66% <0.00%> (+6.77%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Seems like there is a genuine failure. Can you check? 😅 https://github.com/line/centraldogma/actions/runs/3135905322/jobs/5092148722#step:5:29
FAILURE: Build failed with an exception.
* Where:
Script '/home/runner/work/centraldogma/centraldogma/gradle/scripts/lib/common-dependencies.gradle' line: 170
* What went wrong:
A problem occurred evaluating script.
> No signature of method: java.util.Optional.isEmpty() is applicable for argument types: () values: []
Possible solutions: empty(), identity(groovy.lang.Closure), inspect(), dump()
I missed linking to the patch of the bug. It will be fixed by https://github.com/line/gradle-scripts/pull/128
👍 👍 👍