Results 401 comments of Joyee Cheung

I think @richardlau meant that you only need to keep the commit message as-is and additional URLs will be added when they land on v20.x-staging.

This is blocking the require(esm) backport. I will try to backport it again.

(Note that @nodejs/core is not that smaller than the entire collaborators team and is only used for organizational purposes, we don't usually ping it to avoid spamming uninterested people). If...

It's expected that embedders take the internal `require()` and do some other stuff of their own before they go on executing a user script, creating a user-land require with `require('module').createRequire()`...

`__dirname` is not available because the script that gets executed by `LoadEnvironment` is not treated as user-land modules. `__dirname` is only a concept available in CJS modules. It doesn't make...

Started three builds to see which commit introduced the regression or whether it was caused by infra: https://ci.nodejs.org/job/node-test-commit-linux-containered/44134/ https://ci.nodejs.org/job/node-test-commit-linux-containered/44135/ https://ci.nodejs.org/job/node-test-commit-linux-containered/44136/

Looks like 4c730aed7f825af1691740663d599e9de5958f89 broke the test. Opened to revert it for now to make the CI green https://github.com/nodejs/node/pull/53582.

I haven't been able to reproduce this locally yet, but from the logs: ``` 20:38:52 + [ 20:38:52 + { 20:38:52 + offset: '0x40', 20:38:52 + slice1: '000000b30b6c5ab8eea9aa31322e342e', 20:38:52 +...

I am still unable to reproduce it with `./configure --shared-openssl` or `./configure --with-intl=small-icu`, neither on macOS nor on Ubuntu 23.04...but I could try logging into one of the containers to...

Ah, I could reproduce it now, it needs a separately installed shared openssl.