Joyee Cheung
Joyee Cheung
Locally this patch fixes it for me (it is rather curious why this only shows up in dynamically linked builds, though..): https://chromium-review.googlesource.com/c/v8/v8/+/5662576 Trying it in the CI: https://ci.nodejs.org/job/node-test-commit-linux-containered/44167/
> I agree. Unfortunately, I couldn't figure out some weird npm issue on my Windows machine, and couldn't make a progress due to the slowness of the benchmarks (even if...
Oh I see in https://github.com/nodejs/node/issues/53538 you were trying to run `node-benchmark-compare`. You could just send that over to any machine that can run `node-benchmark-compare` to analyze the data, the csv...
Microbenchmark CI https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1571/
From the logs the Windows failure is likely to be different from the one on the dynamically linked builds, maybe some patches are not backported to v22.x and caused a...
I see, on 32-bit Windows I suspect it's a padding issue - maybe https://github.com/nodejs/node/pull/53563 fixes it?
Opened https://github.com/nodejs/node/pull/53596 for the simpler case of NODE_OPTIONS, when the worker spawning code does not intend to modify NODE_OPTIONS and only copies the one from the parent because they want...
cc original reviewers of https://github.com/nodejs/node/pull/50983 @lemire @jasnell @legendecas
For some reason, the value-initialize trick is not working in dynamically linked builds. So I removed the update and got the branch back to the original shape.
The tests are still broken, so it may be something that landed in the main branch after cd8e61fe2630906fc53de6ff9b98ef8355533785 that broke it (or could be the build infra?)