Joyee Cheung
Joyee Cheung
Some discoveries: 1. We need to return non-empty data for pointer values in context data otherwise V8 would still serialize them verbatim (that was what this PR used to do,...
Oof, CI is finally green. Can I get some reviews please? @nodejs/cpp-reviewers @nodejs/startup @nodejs/build @legendecas
Given that this can be reproduced with various completely different snippets this looks more like a V8 issue than a Node.js issue. Each major version of Node.js typically gets a...
> I plan to slowly organize the parallel tests into sub folders. Do we have consensus on this being feasible? At least I am not seeing positive signals from https://github.com/nodejs/node/issues/52502...
> Instead of scrolling through a long list, contributors can quickly navigate to the relevant subfolder, reducing time spent searching for files. There are many commands one can use to...
> As the project expands, new tests can be added to the appropriate subfolder without cluttering the main test directory Actually I think as the folders grow it would be...
After some experiments it seems the option that makes the most sense is what @addaleax proposed in https://github.com/nodejs/node/pull/53086#issuecomment-2128056793 so I did a prototype here for `Isolate::Free()` and `IsolateDisposeFlags::kDontFree`. Will need...
It seems the original flakes are not coming back, though I am unable to reproduce them in the first place, I wonder if the original reasoning already no longer applies...
Communicated with mlippautz offline and it seems the owned CppHeap implementation is still experimental and not ready yet (I guess that's why AttachCppHeap/DetachCppHeap are still just DEPRECATED_SOON, not DEPRECATED), we...
> Also tho... 5000+ files changed!? does this need to be rebased? or is it really that big? This is based on https://github.com/nodejs/node/pull/57753 to check if it works with 13.6....