Joyee Cheung
Joyee Cheung
Rebased since https://github.com/nodejs/node/pull/44192 and https://github.com/nodejs/node/pull/44203 has landed
Landed in dab205748dde...fddc701d3c0e
@goloveychuk Thanks for the report, this is just a guess but can you try it with https://chromium-review.googlesource.com/c/v8/v8/+/3793525 ? If it shows up again, can you try building Node.js with the...
@goloveychuk Thanks for the follow-up. Is the code causing this error related to https://github.com/nodejs/node/issues/40832#issuecomment-1155320869 by any chance?
@goloveychuk This looks like a duplicate of https://bugs.chromium.org/p/v8/issues/detail?id=13149 - can you try building with https://chromium-review.googlesource.com/c/v8/v8/+/3813068 and see if the crash goes away?
The proposal makes sense to me in general, though regarding: > The entry point hooks may allocate handles that persist across the boundary between phases (e.g. network handles, file descriptors,...
Another issue not completely related to CPU utilization: we should still support the benchmark on older versions of Node.js whenever possible. We can just disable the tests that require async/await...
After talking with @fengmk2 just learned that the number of workers is hard-coded to prevent Travis CI flakiness. I will try to fix dispatch.js and compatibility with older versions of...
I don't think "doc-only" is enough to decide a patch can be fast-tracked. At least we need to consider number of lines changed as well.
The idea itself SGTM but when an issue is labeled with the `wrong-repo`, the "right repo" might not necessarily be `nodejs/help`, how can the bot know which repo to redirect...