node icon indicating copy to clipboard operation
node copied to clipboard

[v20.x backport] src: move package_json_reader cache to c++

Open anonrig opened this issue 1 year ago • 8 comments

Backports https://github.com/nodejs/node/pull/50322 to v20

cc @nodejs/releasers @joyeecheung @GeoffreyBooth

anonrig avatar Jun 18 '24 16:06 anonrig

Review requested:

  • [ ] @nodejs/actions
  • [ ] @nodejs/gyp
  • [ ] @nodejs/loaders
  • [ ] @nodejs/security-wg
  • [ ] @nodejs/startup
  • [ ] @nodejs/tsc
  • [ ] @nodejs/url

nodejs-github-bot avatar Jun 18 '24 16:06 nodejs-github-bot

Backport-PR-URL should refer to this PR (while PR-URL refers to the original PR). You don't need to manually add Backport-PR-URL to the commits as node-core/utils will add if missing (if git node land --backport is used to land).

richardlau avatar Jun 18 '24 16:06 richardlau

CI: https://ci.nodejs.org/job/node-test-pull-request/59869/

nodejs-github-bot avatar Jun 18 '24 16:06 nodejs-github-bot

Backport-PR-URL should refer to this PR (while PR-URL refers to the original PR). You don't need to manually add Backport-PR-URL to the commits as node-core/utils will add if missing (if git node land --backport is used to land).

I used git node backport 50322 --to=20 but unfortunately it didn't add at all. I'll update the PR once the existing tests pass (to avoid re-running again)

anonrig avatar Jun 18 '24 16:06 anonrig

I think @richardlau meant that you only need to keep the commit message as-is and additional URLs will be added when they land on v20.x-staging.

joyeecheung avatar Jun 18 '24 16:06 joyeecheung

can you please rebase? there are some undici commits we removed from staging

marco-ippolito avatar Jun 26 '24 10:06 marco-ippolito

CI: https://ci.nodejs.org/job/node-test-pull-request/60336/

nodejs-github-bot avatar Jul 15 '24 15:07 nodejs-github-bot

@anonrig there is some issue with the backport, does not compile

marco-ippolito avatar Jul 30 '24 14:07 marco-ippolito

This is blocking the require(esm) backport. I will try to backport it again.

joyeecheung avatar Jan 13 '25 16:01 joyeecheung