node
node copied to clipboard
[v20.x backport] src: move package_json_reader cache to c++
Backports https://github.com/nodejs/node/pull/50322 to v20
cc @nodejs/releasers @joyeecheung @GeoffreyBooth
Review requested:
- [ ] @nodejs/actions
- [ ] @nodejs/gyp
- [ ] @nodejs/loaders
- [ ] @nodejs/security-wg
- [ ] @nodejs/startup
- [ ] @nodejs/tsc
- [ ] @nodejs/url
Backport-PR-URL should refer to this PR (while PR-URL refers to the original PR). You don't need to manually add Backport-PR-URL to the commits as node-core/utils will add if missing (if git node land --backport is used to land).
CI: https://ci.nodejs.org/job/node-test-pull-request/59869/
Backport-PR-URLshould refer to this PR (whilePR-URLrefers to the original PR). You don't need to manually addBackport-PR-URLto the commits as node-core/utils will add if missing (ifgit node land --backportis used to land).
I used git node backport 50322 --to=20 but unfortunately it didn't add at all. I'll update the PR once the existing tests pass (to avoid re-running again)
I think @richardlau meant that you only need to keep the commit message as-is and additional URLs will be added when they land on v20.x-staging.
can you please rebase? there are some undici commits we removed from staging
CI: https://ci.nodejs.org/job/node-test-pull-request/60336/
@anonrig there is some issue with the backport, does not compile
This is blocking the require(esm) backport. I will try to backport it again.