Joyee Cheung

Marking it as a good first issue - feel free to try cross-platform SEA generation and update the docs with better instructions on how to do it (as mentioned before...

Yes, unless someone else made it happen before you.

IMO it doesn’t make sense to eagerly detect the format at resolve, the format should only be confirmed during loading, when the source becomes available. Until then it should be...

> Generally speaking, eliminating the resolve time "hint" detection everywhere would be a breaking change and it is IMO out of scope for this PR. Doesn't this PR "improves" the...

Is the failing test something like https://github.com/dygabo/node/blob/fix-for-unflagging-module-format-detection/test/fixtures/es-module-loaders/builtin-named-exports-loader.mjs#L31 ? In that case I think it's the test that's making wrong assumptions - the loader hook should not count on the `context.format`...

In terms of format, I think there are actually two concepts: 1. Assumed format 2. Confirmed format e.g. if it's a `.js` file not bound by a type field in...

I think this is different from https://github.com/nodejs/node/pull/51295 in that, the other PR only used the C++ version in a not very well-tested branch (only when permission is enabled) so if...

Somehow this is reproducible locally (macOS + x64 & arm64), and in the CI, on FreeBSD and SmartOS, but not on others. There are still 3-4 words of differences in...

Split the context data callback part to https://github.com/nodejs/node/pull/53217 - at least that makes the context data slots serialized with some non-gibberish (empty values), otherwise V8 might run into issues serializing...

Yes, in this PR are still some utilities for checking reproducibility and a test for that (but it's not currently passing because a few other bytes are still not reproducible,...