Joyee Cheung
Joyee Cheung
> Would it be possible to annotate the source code with comments, indicating which underscore properties are OK from the linter's point of view? I just did a quick search...
New Rule: disallow bidirectional control characters and homoglyphs to mitigate trojan source attacks
The examples only demonstrate how these characters can be used for malicious intent. What the linter can do can be much simpler than trying to identify these attacks - just...
New Rule: disallow bidirectional control characters and homoglyphs to mitigate trojan source attacks
Yes, the BiDi control characters is a very specific small set. Homoglyphs can be somewhat tricky to determine, though perhaps the Unicode confusables database can be a good reference. Regarding...
New Rule: disallow bidirectional control characters and homoglyphs to mitigate trojan source attacks
@mdjermanovic I didn't have a specific plan about how homoglyphs should be detected when I opened this - it was mostly about starting a discussion. But my two cent is...
> From what I understand, the decision to not support NODE_PATH for ES6 modules was a deliberate one. There is no official way of setting the root of ES6 modules?...
I don't think the reliability report considers tests that are marked as flaky: https://github.com/nodejs/node-core-utils/blob/0d49edaf6736b393b0597ee67d70381cd5841b40/lib/ci/ci_failure_parser.js#L157-L170 (perhaps we should, for the walk command used by the reliability report), but as far as...
cc @nodejs/undici Maybe a separate PR could be done in undici to replace `’` with `'` to avoid making the bundle a two-byte string. From a glance they only show...
> If you replace the GetOctalCode with the following code... Good catch though I don't think that's relevant for this PR as it only moved existing code to another C++...
I think I can attend the first 30 minutes but will need to go after that or I will have no bed to sleep on...
(Or maybe I can rejoin after leaving for ~15 minutes, not too sure)