Joyee Cheung

This sounds like a nodejs/node issue. We are also looking into it for single executable applications for example https://github.com/nodejs/single-executable/issues/37

I have a proposed fix for `vm.compileFunction()` in https://github.com/nodejs/node/pull/46785 - I think this should solve the leak for functions (when the importModuleDynamically is noop), but it needs module wraps to...

So I gave this another look while working on another memory issue and I found out why the original fix to vm.compileFunction crashed https://github.com/nodejs/node/issues/47096 - the initial assumption was that...

OP actually contains two leaks - the leak of `vm.compileFunction()` when `importModuleDynamically` and the leak of `vm. SyntheticModule`. https://github.com/nodejs/node/pull/48510 should fix the two, but `vm.SourceTextModule` would still be leaking because...

The latest news is that https://github.com/nodejs/node/pull/48510 needs a reland of a V8 patch (https://chromium-review.googlesource.com/c/v8/v8/+/4834471) before it can go ahead (the V8 patch should be ready to land, but I'll push...

Closing as https://github.com/nodejs/node/pull/48510 has landed. We can re-open if that turns out to be incorrect (hopefully not).

@stas-sisense https://github.com/nodejs/node/pull/48510 has landed on the main branch, you can try it out using the nightlies (e.g. see https://gist.github.com/joyeecheung/083f6b6d601e64382121001ab87bbed2 on how to install nightlies) or wait for a v20.x release...

`navigator.platform` is [a deprecated API](https://developer.mozilla.org/en-US/docs/Web/API/Navigator/platform). If we are adding the Navigator interface we probably should start with something that's not deprecated...The value of `navigator.platform` is also unspecified, I wonder how...

From the CI this is failing on Windows: ``` 21:27:57 > python "C:\workspace\node-test-binary-windows-native-suites\node\tools\build_addons.py" "C:\workspace\node-test-binary-windows-native-suites\node\test\addons" 21:28:28 Generating headers 21:28:28 Traceback (most recent call last): 21:28:28 File "C:\workspace\node-test-binary-windows-native-suites\node\tools\build_addons.py", line 129, in 21:28:28...

In https://github.com/nodejs/node/issues/51448#issuecomment-1890829515 it was mentioned that console.log() can swallow the error too (by default, console.log() swallows all errors except stack overflow). I'd prefer that instead of special casing EPIPE since...