Joyee Cheung
Joyee Cheung
@gibfahn Yes, it just prints an error and then keeps running, similar to what it does when trying to load a non-existent coredump. Of course `v8` commands would be `Unrecognized...
hm, I don't exactly remember why `runSync` throws on non-empty stderr, but I think we can switch the condition to `if (child.status !== 0)`. If anything comes back weird we...
It should be good to add a question here about copying it and use `clipboardy.writeSync` to copy it.
Reminder: this is not yet fixed because of 3 in the OP
@addaleax > I’d go with “yes”, for all of these :) +1 @Tiriel > +1, could be implemented by checking the right label (again). In this case I am afraid...
So I've given it a bit of thought, turns out this should be the job of `core-validate-commit`. There is no need to "get the file changed" if the file is...
@targos The easiest way to get this done is to operate on a per-PR basis i.e. do not mix V8 update commits in normal PRs otherwise it's hard to get...
Also it might be easier if we just take the original commit id and generate the commit message, then compare it against the current one, given that V8 commits are...
@targos It's always hard to get the squashing right if it's not "squash everything to one commit", the user must explicitly tell the tool which commit they want to keep...
By the way I think we can work around the 48h wait if the PR are submitted separately but reviewed together? I tend to submit multiple PRs where one includes...