node icon indicating copy to clipboard operation
node copied to clipboard

Published 20 hours ago • verified publisher icon nodejs

test: remove flaky designation

Open lpinca opened this issue 1 year ago • 5 comments

Searching the automatically-generated test failure reports in the issues at https://github.com/nodejs/reliability/issues, I don't see test-worker-message-port-message-before-close failing any time recently.

lpinca avatar Feb 12 '24 20:02 lpinca

Isn't it because of https://github.com/nodejs/build/pull/3598?

aduh95 avatar Feb 12 '24 21:02 aduh95

There should be failures in https://github.com/nodejs/reliability/issues before https://github.com/nodejs/build/pull/3598 landed, no?

lpinca avatar Feb 13 '24 19:02 lpinca

CI: https://ci.nodejs.org/job/node-test-pull-request/57093/

nodejs-github-bot avatar Feb 15 '24 11:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57106/

nodejs-github-bot avatar Feb 15 '24 17:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57132/

nodejs-github-bot avatar Feb 16 '24 11:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57302/

nodejs-github-bot avatar Feb 22 '24 18:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57387/

nodejs-github-bot avatar Feb 24 '24 19:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57441/

nodejs-github-bot avatar Feb 26 '24 20:02 nodejs-github-bot

I don't think the reliability report considers tests that are marked as flaky: https://github.com/nodejs/node-core-utils/blob/0d49edaf6736b393b0597ee67d70381cd5841b40/lib/ci/ci_failure_parser.js#L157-L170 (perhaps we should, for the walk command used by the reliability report), but as far as I've seen it's not been failing recently.

joyeecheung avatar Feb 27 '24 17:02 joyeecheung

CI: https://ci.nodejs.org/job/node-test-pull-request/57470/

nodejs-github-bot avatar Feb 27 '24 17:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57472/

nodejs-github-bot avatar Feb 27 '24 18:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57475/

nodejs-github-bot avatar Feb 27 '24 19:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57493/

nodejs-github-bot avatar Feb 28 '24 20:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57513/

nodejs-github-bot avatar Feb 29 '24 19:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57515/

nodejs-github-bot avatar Feb 29 '24 21:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57539/

nodejs-github-bot avatar Mar 01 '24 18:03 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57544/

nodejs-github-bot avatar Mar 02 '24 05:03 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57545/

nodejs-github-bot avatar Mar 02 '24 06:03 nodejs-github-bot

Landed in 5c97f411d813b5d9783ced28fe3f968f568e1ffa

nodejs-github-bot avatar Mar 02 '24 11:03 nodejs-github-bot