react icon indicating copy to clipboard operation
react copied to clipboard

Update Banner.tsx

Open lukasoppermann opened this issue 1 year ago • 2 comments

Remove the use of --space tokens

Related to https://github.com/primer/primitives/pull/956

Changelog

Replaced space token with equal base size token.

Rollout strategy

  • [ ] Patch release
  • [ ] Minor release
  • [ ] Major release; if selected, include a written rollout or migration plan
  • [x] None; if selected, include a brief description as to why

It should have no impact on the users.

Testing & Reviewing

Merge checklist

  • [ ] Added/updated tests
  • [ ] Added/updated documentation
  • [ ] Added/updated previews (Storybook)
  • [ ] Changes are SSR compatible
  • [ ] Tested in Chrome
  • [ ] Tested in Firefox
  • [ ] Tested in Safari
  • [ ] Tested in Edge
  • [ ] (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

lukasoppermann avatar May 16 '24 08:05 lukasoppermann

🦋 Changeset detected

Latest commit: a39b25643d3455dbe9de6dc966458d8b1d157aec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar May 16 '24 08:05 changeset-bot[bot]

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 89.35 KB (0%)
packages/react/dist/browser.umd.js 89.67 KB (0%)

github-actions[bot] avatar May 16 '24 08:05 github-actions[bot]

@lukasoppermann when you have a sec, could you add a changeset as a patch that talks about the changes to the CSS Custom Properties used? Thanks!

joshblack avatar May 20 '24 16:05 joshblack

@joshblack do we want a release for this? There is no change to the output.

lukasoppermann avatar May 22 '24 18:05 lukasoppermann