Jon Atack

> Not sure if this is worth it... we might as well turn on fullrbf by default. I agree.

It seems to me the linked issue would be solved in the general case by https://github.com/bitcoin/bitcoin/pull/24545 (or alternatively since v22 by adding manual connections to other non-clearnet networks). > In...

> > Manual connections are to trusted peers, so if I understand correctly, the specific threat model here is that of a trusted peer fingerprinting us? > > My understanding...

Attempted a couple of week-long Twitter surveys related to this topic at https://twitter.com/jonatack/status/1524377548062351360 and https://twitter.com/jonatack/status/1524380125126660096.

> I am also running into this locally sometimes Same.

Concept ACK

Interesting simplification and looks reasonable at first glance. A possible alternative would be to retain the checks and make `LookupSubNet` return `std::optional` instead. ``` rpc/net.cpp:717:9: error: no matching function for...

Updated per @MarcoFalke's feedback (thanks!). git diff bd56f68 e2f5c29 ```diff diff --git a/src/bitcoin-cli.cpp b/src/bitcoin-cli.cpp index 04d72ade3d..a8293afdc7 100644 --- a/src/bitcoin-cli.cpp +++ b/src/bitcoin-cli.cpp @@ -467,8 +467,8 @@ public: if (!batch[ID_NETWORKINFO]["error"].isNull()) return batch[ID_NETWORKINFO];...

Updated per @mzumsande and @luke-jr review feedback (thanks).

> It [-netinfo] should really be a best-effort component of bitcoin-cli, that just adapts to any code changes we make That's what is done here, as well as in #25176,...