bips icon indicating copy to clipboard operation
bips copied to clipboard

Base58chk-encoded extended keys are always 111 characters long. Amend wording of BIP accordingly

Open mmgen opened this issue 5 years ago • 1 comments

Base58chk-encoded extended keys are always 111 characters long. Amend wording of BIP accordingly.

Diff: -This results in a Base58-encoded string of up to 112 characters. +This results in a Base58-encoded string of exactly 111 characters.

Proof: Version bytes: 0x0488b21e (“xpub”), 0x0488ade4 (“xprv”), 0x043587cf (“tpub”), 0x04358394 (“tprv”)

Largest version byte is 0x0488b21e, smallest 0x04358394.

Largest “possible” key:

kL = 0x0488b21effffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff (78 bytes)
b58chk(kL) = xpubEPi3iGSX9RiyuXPTijevUmMctBDQs2TWCMgUd3qKp6qCgUc8RUsPdPBrRC6whFeWTg37DcmnJJiKFL73DH4sjdApJkXBD3vFcBP4xHq3fPY
len(b58chk(kL)) = 111

Smallest “possible” key:

kS = 0x043583940000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 (78 bytes)
b58chk(kS) = tprv8ZgxMBicQKsPcsbCVeqqF1KVdH7gwDJbxbzpCxDUsoXHdb6SnTPYxdwSAKDC6KKJzv7khnNWRAJQsRA8BBQyiSfYnRt6zuu4vZQGKjeW4YF
len(b58chk(kS)) = 111

mmgen avatar Sep 27 '18 18:09 mmgen

@sipa

luke-jr avatar Sep 27 '18 18:09 luke-jr

Agree, closing. As the author was last active six years ago, I'll open separate BIP-specific pulls with a cherry-picked commit by the original author.

jonatack avatar Apr 30 '24 21:04 jonatack

Superseded by https://github.com/bitcoin/bips/pull/1584 that cherry-picks 81644ddfa131bb0e387ead2cc309ca18e57542b1.

jonatack avatar Apr 30 '24 21:04 jonatack