Jon Atack

Results 269 comments of Jon Atack

(BIP155 network IDs are implemented in Bitcoin Core, for instance, in the following enum) ```cpp /** * BIP155 network ids recognized by this software. */ enum BIP155Network : uint8_t {...

Thank you, @laanwj!

ACK, no alteration of meaning in the text AFAICT. Pinging @sipa for sign-off on the second commit.

@katesalazar There doesn't seem to be much support for this change. Are you still working on this PR, and if not, would you consider closing it?

ACK ce5d831516bfdb34904a765b3f742e38621ec036 I agree with @murchandamus as well.

> Personally, I'd like to discourage adding implementation lists. It just makes noise on the BIP PRs... Agree. Implementation lists have been removed in recent merged pulls for the reasons...

> @luke-jr Already fixed in #724. Thanks! Closing as already fixed.