Enhance wp_hash function to support custom hashing algorithms
Trac ticket: https://core.trac.wordpress.org/ticket/62005
Summary
This PR updates the wp_hash function to allow users to specify a custom hashing algorithm, enhancing the security and flexibility of the function. Previously, the function hardcoded the md5 algorithm, which is vulnerable to collision attacks.
Changes:
- Added a new parameter
$algoto thewp_hashfunction, allowing users to specify the hashing algorithm. The default remainsmd5for backward compatibility. - Implemented a check using
hash_hmac_algos()to ensure the provided algorithm is supported. If not, the function will fall back tomd5.
Benefits:
- Users can now choose more secure hashing algorithms like
sha256. - Improved security by allowing the use of modern, collision-resistant hashing algorithms.
Backward Compatibility:
- The function retains
md5as the default algorithm, ensuring backward compatibility with existing code.
Testing:
- Tested with various algorithms (
md5,sha256,sha512) to confirm correct functionality. - Validated fallback to
md5when an unsupported algorithm is provided.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.
Hi @PushpenderIndia! 👋
Thank you for your contribution to WordPress! 💖
It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!
No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.
Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.
More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook.
Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.
If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.
The Developer Hub also documents the various coding standards that are followed:
- PHP Coding Standards
- CSS Coding Standards
- HTML Coding Standards
- JavaScript Coding Standards
- Accessibility Coding Standards
- Inline Documentation Standards
Thank you, The WordPress Project
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
Core Committers: Use this line as a base for the props when committing in SVN:
Props pushpenderindia, debarghyabanerjee, johnbillion.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.
Test using WordPress Playground
The changes in this pull request can previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.
Some things to be aware of
- The Plugin and Theme Directories cannot be accessed within Playground.
- All changes will be lost when closing a tab with a Playground instance.
- All changes will be lost when refreshing the page.
- A fresh instance is created each time the link below is clicked.
- Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance, it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.
Committed in https://core.trac.wordpress.org/changeset/59578