John Blackbourn comments

Results 494 comments of


                                            John Blackbourn

Introduce a JSON schema for composer.json

I think centralising the _list of modules_ for this purpose is reasonable and manageable. As far as I know we don't have a high turnover of new or removed modules....

Update telemetry settings to reflect the effect they have

Ok thanks. The language needs to be clarified in that case.

Slow behaviour on admin-ajax requests

Are you seeing the same issue on the main Posts listing screen in the admin area (at `wp-admin/edit.php`)? I just checked another site and it is indeed performing a query...

Make a decision about editorial owner and attributed author controls

I really like the idea of 2 but it means introducing the concept of editorial owners as well as attributed users. I can see this being really useful for certain...

Make a decision about editorial owner and attributed author controls

Perhaps option 2 as an opt-in feature?

Feat add author name

I'm hoping to be able to arrange some time for someone to work on Authorship soon

Provide markup for core/post-author block

Related: #58

Provide markup for core/post-author block

This needs to apply to the `core/avatar` and `core/post-author-name` blocks too

Adding attribute_post_type does not allow you to attribute_post_type

There should be test coverage for this in `TestCapabilities`. What's missing from the tests?

Adding attribute_post_type does not allow you to attribute_post_type

I would expect the `testGuestPostAttributionCanBeGranted()` and `testGuestAuthorCreationCanBeDenied()` to handle both of these situations, but those tests only test the capabilities, not the actual functionality, so there might be something missing...