wordpress-develop icon indicating copy to clipboard operation
wordpress-develop copied to clipboard

Add action for third party library changes

Open johnbillion opened this issue 1 year ago • 11 comments

Trac ticket: https://core.trac.wordpress.org/ticket/54510

johnbillion avatar May 13 '24 19:05 johnbillion

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props johnbillion, szepeviktor, desrosj.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions[bot] avatar May 13 '24 19:05 github-actions[bot]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance, it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

github-actions[bot] avatar May 13 '24 19:05 github-actions[bot]

@johnbillion This new workflow does not start. Maybe because "on" event != event_name

szepeviktor avatar May 13 '24 19:05 szepeviktor

You can easily debug the current "github" context: https://github.com/szepeviktor/byte-level-care/blob/6aaffb792e2f1e5f535f7bff83a969353d1966cb/.github/workflows/workflow.yml#L48-L63

szepeviktor avatar May 13 '24 19:05 szepeviktor

@johnbillion I would simply use GH CLI: https://cli.github.com/manual/gh_pr_comment

szepeviktor avatar May 13 '24 21:05 szepeviktor

I'm trying to use the same approach as in the other workflows so we don't have too many different implementations of the same thing: https://github.com/WordPress/wordpress-develop/blob/trunk/.github/workflows/pull-request-comments.yml#L165

johnbillion avatar May 13 '24 21:05 johnbillion

All right! Ditch the one short command line.

szepeviktor avatar May 13 '24 21:05 szepeviktor

I think the permissions issue is due to this being a PR from a fork.

johnbillion avatar May 13 '24 21:05 johnbillion

this being a PR from a fork.

You could add && ! github.event.pull_request.head.repo.fork

szepeviktor avatar May 13 '24 22:05 szepeviktor

Moved the testing to https://github.com/johnbillion/wordpress-develop/pull/2

johnbillion avatar May 13 '24 22:05 johnbillion

Instead of escaped backticks you could write: <code>src/wp-includes/Text</code>

szepeviktor avatar May 13 '24 22:05 szepeviktor