Joshua Charkow
Joshua Charkow
Some refactoring was done in the https://github.com/Roestlab/massdash/pull/106 More refactoring might need to be done?
@irahorecka @singjc Likely more tests are needed for the GUI however I am not sure the best way to go about it since it seems like all the buttons are...
sorry other comments got deleted basically it seems that when converting from featureMap to spectra still lots of signals that appear the same maybe they have very minor numerical inaccuracies?...
I only tested on IM and RT so yes might be an issue
Removing CV term list is probably fine. However this would break traml support.
Current implementation (maybe rename ReactionMonitoringTrasitionTwo) is sufficient for current purposes if needed. Will revisit once apache arrow support is added.
Yes I think that this is good to merge now on my end
Downstream processing tools like pyprophet only use columns that start with `var` so it should not affect pyprophet results.
In order to make the parameters less confusing I added a way to automatically determine if sonar, peak shape scores and ms1 are found so do not have to pass...