Joshua Charkow
Joshua Charkow
> a) we provide more flexibility by allowing callback functions b) IMHO it fits better in MsExperiment c) this version is inherently parallelized d) it traverses the spectrum only once...
Sorry I don't have any experience with agilent data. Yes the way it is stored now you should be able to use spectrum.getDriftTime(). It looks like from the snippet you...
@Nishantrde let me know if you are interested in working on this
> I would suggest maybe adopting `facet_col`/`facet_row` similar to how plotly does it. > > https://plotly.com/python/facet-plots/ Yes this would be preferred to `tile_by`
was this issue addressed? Ran into this issue and it is quite annoying!
Have not done a complete review yet however, it seems that we are getting some failed tests. I expect some to fail since you are updating the code however I...
@Imama-Kainat can you please link to the issue this is solving (e.g. edit the description and add the issue that this addresses)
> Hi @jcharkow I have solved most of the conflicts if you want you can review it. > I'll wait untill all the conflicts are solved and then I'll review
In theory this should work however, the ci tests will likely have to be updated because they are all visual tests and thus very specific to all the versions that...
Note to self: things to look into - DeepDiff - https://zepworks.com/deepdiff/current/ - Fuzzy Logic with pngs - ```# Compare with baseline using perceptual hashing baseline = imagehash.average_hash(Image.open("baseline.png")) current = imagehash.average_hash(Image.open("plot.png"))...