Joshua Charkow

icon company University Of Toronto icon location PhD candidate in the Röst lab at the University of Toronto. Interested in computational mass spectrometry and single cell proteomics.

Results 73 comments of Joshua Charkow

IM peak picking

> I am having some difficulty how the centroided data differs from the concatenated data. >> I am also not 100% sure (ping @cbielow) but my impression was that CONCATENATED...

Add memory-efficient .oswpq parser with PyArrow lazy evaluation

@copilot address reviewer comments

Add memory-efficient .oswpq parser with PyArrow lazy evaluation

@copilot update API documentation

Add memory-efficient .oswpq parser with PyArrow lazy evaluation

@copilot address reviwer comments

Add memory-efficient .oswpq parser with PyArrow lazy evaluation

@singjc can I merge this?

Add memory-efficient .oswpq parser with PyArrow lazy evaluation

@singjc can you try and get copilot to address the changes again? I lost access to my github ed account. If not I will address the comments manually

Add memory-efficient .oswpq parser with PyArrow lazy evaluation

Thanks for finishing this up!

additional convenience functions for MSExperiment

> Very cool. Thanks for finishing. Yes for the python guys, please try. Maybe the ms_level arg breaks the interface. Try to use as much of the new functionality if...

additional convenience functions for MSExperiment

> another question: if we provide a range 1-2, should it be [1,2] or [1,2) ? I think [1,2] would be more natural and follows ouer range convention I think...

additional convenience functions for MSExperiment

Something I forgot to ask in the meeting today. I know in OpenSwath we also have Chromatogram extraction algorithms (https://github.com/OpenMS/OpenMS/blob/develop/src/openms/source/ANALYSIS/OPENSWATH/ChromatogramExtractorAlgorithm.cpp) . Is there a reason why those functions are not...