massdash icon indicating copy to clipboard operation
massdash copied to clipboard

Plot Interface Refactoring

Open jcharkow opened this issue 1 year ago • 3 comments

Refactor plotting documentation for easier interaction with python interface/jupyter notebook interface. I am not too sure which strategy would be best.

Some ideas:

Remove the config interface and directly take in parameters on initiation.

plotting methods directly built into structs?

jcharkow avatar Jan 03 '24 15:01 jcharkow

I kind of like the config interface to avoid having too many parameters in the method call, unless we use **kwargs to pass parameters directly to the plotting (bokeh figure/ plotly figure) interfaces (which may be limited).

I like the idea of having the plotting methods also directly part of the structs.

singjc avatar Jan 03 '24 17:01 singjc

I don't mind the config its just don't really like how some parameters are not relevant for certain plots. Maybe the plot config should be directly parameters of the respective plotters? not a general thing? I am not sure will have to think about it more

jcharkow avatar Jan 03 '24 19:01 jcharkow

Some refactoring was done in the https://github.com/Roestlab/massdash/pull/106 More refactoring might need to be done?

jcharkow avatar Feb 27 '24 18:02 jcharkow