James M Snell comments

Results 522 comments of


                                            James M Snell

trafficstars

test: update test-abortsignal-cloneable to use node:test

There are relevant test failures to investigate.

test: update test-abortsignal-cloneable to use node:test

Landed in 2bd0f99e778e

test: update test-aborted-util to use node:test

> ... how do I know which Node core modules are safe to use and which would require the lazySpawn() treatment? I'd imagine that folks would write the test specifically...

test: update test-aborted-util to use node:test

Landed in 097dcfcb1f4c

test: update test-assert to use node:test

Landed in fc02b88f89f8...9cbef482df41

Support .noderc or similar file-based initialization configurations?

Putting the data format aside, we should talk about resolution of these files. Where would they live relative to the application? Current working directory only? In the `node_modules` path? I...

test: move a couple of tests over to using node:test

Landed in c44d41b2d819

add `path.mimeType()` and `path.charset()` to `node:path`

For `path.mimeType(...)` a couple of questions... 1. Would you expect the actual path to be resolved and for the mime type to be sniffed from the contents or based entirely...

test: refactor test-abortcontroller to use node:test

> Not that I mind, but I'm curious what the motivation is for this? I'm assuming something related to Workers. Key motivation is make the tests more structured and easier...

test: refactor test-abortcontroller to use node:test

> ... Using BDD specific syntax does not help. As someone who has been working to port many of these tests to another runtime adding this kind of structure does...