node
node copied to clipboard
nodejs
test: update test-assert to use node:test
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 87.32%. Comparing base (
4f1c27a) to head (23adad3). Report is 61 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #54585 +/- ##
==========================================
- Coverage 87.33% 87.32% -0.01%
==========================================
Files 649 649
Lines 182620 182620
Branches 35042 35039 -3
==========================================
- Hits 159490 159478 -12
- Misses 16394 16403 +9
- Partials 6736 6739 +3
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Commit Queue failed
- Loading data for nodejs/node/pull/54585 ✔ Done loading data for nodejs/node/pull/54585 ----------------------------------- PR info ------------------------------------ Title test: update test-assert to use node:test (#54585) Author James M Snell <[email protected]> (@jasnell) Branch jasnell:use-test-for-test-assert -> nodejs:main Labels test, author ready, needs-ci Commits 3 - test: update test-assert to use node:test - test: update test-assert-typedarray-deepequal to use node:test - test: update multiple assert tests to use node:test Committers 1 - James M Snell <[email protected]> PR-URL: https://github.com/nodejs/node/pull/54585 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54585 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 27 Aug 2024 05:10:26 GMT ✔ Approvals: 2 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/54585#pullrequestreview-2263248081 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/54585#pullrequestreview-2266164379 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-08-29T05:55:07Z: https://ci.nodejs.org/job/node-test-pull-request/61636/ - Querying data for job/node-test-pull-request/61636/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 54585 From https://github.com/nodejs/node * branch refs/pull/54585/merge -> FETCH_HEAD ✔ Fetched commits as beabcec41ca4..23adad3410af -------------------------------------------------------------------------------- [main 4aeb86ca38] test: update test-assert to use node:test Author: James M Snell <[email protected]> Date: Mon Aug 26 21:05:07 2024 -0700 2 files changed, 912 insertions(+), 930 deletions(-) delete mode 100644 test/parallel/test-assert-strict-exists.js [main cd0b7c648d] test: update test-assert-typedarray-deepequal to use node:test Author: James M Snell <[email protected]> Date: Mon Aug 26 21:15:20 2024 -0700 1 file changed, 87 insertions(+), 74 deletions(-) [main 6b4ce531e1] test: update multiple assert tests to use node:test Author: James M Snell <[email protected]> Date: Mon Aug 26 22:08:07 2024 -0700 6 files changed, 1000 insertions(+), 973 deletions(-) ✔ Patches applied There are 3 commits in the PR. Attempting autorebase. Rebasing (2/6)https://github.com/nodejs/node/actions/runs/10619066403Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- test: update test-assert to use node:test
PR-URL: https://github.com/nodejs/node/pull/54585 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
[detached HEAD ccd5210bd5] test: update test-assert to use node:test Author: James M Snell <[email protected]> Date: Mon Aug 26 21:05:07 2024 -0700 2 files changed, 912 insertions(+), 930 deletions(-) delete mode 100644 test/parallel/test-assert-strict-exists.js Rebasing (3/6) Rebasing (4/6)
Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- test: update test-assert-typedarray-deepequal to use node:test
PR-URL: https://github.com/nodejs/node/pull/54585 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
[detached HEAD f86339c706] test: update test-assert-typedarray-deepequal to use node:test Author: James M Snell <[email protected]> Date: Mon Aug 26 21:15:20 2024 -0700 1 file changed, 87 insertions(+), 74 deletions(-) Rebasing (5/6) Rebasing (6/6)
Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- test: update multiple assert tests to use node:test
PR-URL: https://github.com/nodejs/node/pull/54585 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
[detached HEAD 1a97b77ea1] test: update multiple assert tests to use node:test Author: James M Snell <[email protected]> Date: Mon Aug 26 22:08:07 2024 -0700 6 files changed, 1000 insertions(+), 973 deletions(-)
Successfully rebased and updated refs/heads/main.
ℹ Add
commit-queue-squashlabel to land the PR as one commit, orcommit-queue-rebaseto land as separate commits.
Unfortunately, this commit didn't land cleanly on v22.x-staging. I tried to fix the conflicts but tests started to fail. Can you create a manual backport?
