node icon indicating copy to clipboard operation
node copied to clipboard

test: update test-aborted-util to use node:test

Open jasnell opened this issue 1 year ago • 2 comments
trafficstars

jasnell avatar Aug 26 '24 22:08 jasnell

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.29%. Comparing base (4f1c27a) to head (fa0bfe3). Report is 317 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #54578      +/-   ##
==========================================
- Coverage   87.33%   87.29%   -0.04%     
==========================================
  Files         649      649              
  Lines      182620   182620              
  Branches    35042    35045       +3     
==========================================
- Hits       159490   159417      -73     
- Misses      16394    16472      +78     
+ Partials     6736     6731       -5     

see 35 files with indirect coverage changes

codecov[bot] avatar Aug 26 '24 23:08 codecov[bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/61550/

nodejs-github-bot avatar Aug 27 '24 14:08 nodejs-github-bot

... how do I know which Node core modules are safe to use and which would require the lazySpawn() treatment?

I'd imagine that folks would write the test specifically for node.js and those of us who might need to adjust things would have the burden of updating the test or adapting the runtime to it.

Alternatively, we could move the require(...) into the test(...) and gate it with a skip condition like skip: process.getBuiltinModule('child_process') !== undefined

jasnell avatar Aug 28 '24 22:08 jasnell

CI: https://ci.nodejs.org/job/node-test-pull-request/61607/

nodejs-github-bot avatar Aug 28 '24 22:08 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/61619/ 💛

nodejs-github-bot avatar Aug 28 '24 23:08 nodejs-github-bot

Landed in 097dcfcb1f4c

jasnell avatar Aug 29 '24 02:08 jasnell