James M Snell comments

Results 664 comments of


                                            James M Snell

Proposal: Status Code Error Enums

in the protocol, all errors are just pass-through terminal states. Rather than a single value propagating up, you have the pair propagating up. If there are any bob protocol specific...

potential future move to nodejs org

There's no rush.

Proposal: add `offset` to `pull()`

For QUIC, the pattern will be: 1. Sink pulls multiple chunks of data from Source 2. At some arbitrary point in time in the future, Sink notifies Source that a...

Proposal: add `offset` to `pull()`

This could be implemented with an additional flag parameter on `Pull()`. ```c++ class Base { public: typedef enum PullFlags { BOB_FLAG_CLEAR = 0; // Source may clear the data once...

Proposal: add `offset` to `pull()`

Yes, I meant Source. And if the Source does not support retaining the data, then upon seeing the `BOB_FLAG_RETAIN` flag used, it can simply error.

'bob' performance discussion

/cc @addaleax :-)

'bob' performance discussion

@addaleax ... mainly want to just keep you in the loop about the activity here. I know you've got other things you're looking at so no worries at all if...

Loop promise

Loop in smaller chunks that allow the event loop to turn in between chunks.

src: introduce node::Realm

Initial read through is good. It would be helpful to have a better picture of what the additional coming changes will be. Specifically, how is this going to impact individual...

src,process: initial permission model implementation

Given that @addaleax has already left a ton of comments, I'll wait a bit until those are resolved before going through and reviewing myself. Overall, however, on first read through...