James M Snell comments

Results 521 comments of


                                            James M Snell

trafficstars

buffer: make `buflen` in integer range

Landed in 1ba47324e06d

Discuss state of r2 migration on Build WG meeting

Check the certs provided by the server. As a temporary workaround also try setting allow unauthorized to skip the cert validation. It's possibly with either a mismatch in the cname...

src: add web locks api

The CI test failures are not flaky failures. Before running the CI again on this the relevant failures should be looked at

src: add web locks api

There are relevant test failures in CI (web locks web platform tests)

src: add web locks api

I think this is very close! Added a few comments and notice that there are WPT test failures.

src: add web locks api

I still think there may be at least a few issues here relating to how you're using `v8::Global` and `v8::External`. I'd really like to see if we could get @addaleax...

src: modernize cleanup queue to use c++20

Are you missing an `#include `

src: modernize cleanup queue to use c++20

@anonrig do you know if this is still being blocked by macos test runners?

src: modernize cleanup queue to use c++20

@nodejs/platform-macos

url: handle "unsafe" characters properly in `pathToFileURL`

CI is failing but it's unclear if they are all flaky failures or if some subset of the failures are caused by the changes here.