Jared Norman
Jared Norman
@nvandoorn The height/width should be coming from our code though, right? That's why @asfour75's change fixes it.
Thanks for your work on this @mamhoff. Now to find time to actually review it properly... 😅
I've not got a store handy to test whether it works on solidus_multi_domain, but the legacy admin doesn't do it. This would be a functional change in the admin. I...
I'm not necessarily opposed to this change, but can you provide some more context? In all the stores I work on, the order email gets set to the user email...
How does users creating orders for others factor in? Shouldn't that use the `created_by` field?
Thanks for using the deprecator. This still hasn't addressed my other concerns: > Additionally, the DashboardsController is deprecated in a way that simply loading it will trigger the deprecation which...
Nope, I have approved and am just waiting for another person on core to approve.
[This](https://github.com/solidusio/solidus/pull/167/files#diff-3d5717d890ced55ac628baf2e2bda377427a1c00a90939121da7d3d90b48020eR13-R17) could be replaced with a default admin location.
Yeah, that's my thought. It was introduced alongside the permission sets, but I've never seen a store that used it.
The new admin renders this kind of moot, but it couldn't hurt to still do this.