4860-deprecate-and-remove-dashboards-code

[lauriejefferson]

Summary

Fixes #4860 This PR adds deprecation warnings to the following views and controllers:

• DashboardsController
• Home View
• Dashboards Display
• Dashboards Display Spec

[codecov[bot]]

Codecov Report

Merging #5448 (18d6c65) into main (c64e9fd) will decrease coverage by 0.04%. Report is 112 commits behind head on main. The diff coverage is 14.28%.

:exclamation: Current head 18d6c65 differs from pull request most recent head 5e67650. Consider uploading reports for the commit 5e67650 to get more accurate results

@@            Coverage Diff             @@
##             main    #5448      +/-   ##
==========================================
- Coverage   88.86%   88.82%   -0.04%     
==========================================
  Files         607      607              
  Lines       14750    14757       +7     
==========================================
+ Hits        13107    13108       +1     
- Misses       1643     1649       +6     

Files	Coverage Δ
...ore/lib/spree/permission_sets/dashboard_display.rb	100.00% <100.00%> (ø)
...p/controllers/spree/admin/dashboards_controller.rb	0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

[jarednorman]

Thanks for using the deprecator. This still hasn't addressed my other concerns:

Additionally, the DashboardsController is deprecated in a way that simply loading it will trigger the deprecation which is undesirable and the specs themselves don't need to be deprecated. I recommend looking through some past PRs that deprecated things to find some examples of how we've handled similar deprecations in the past to get a feel for how this should be handled.

[lauriejefferson]

I need a little help with the DashboardController deprecation. I searched through past PRs and I see #4102 that may relate. From the PR, It does use a deprecator in the OrdersController, but I'm not sure if that code has also been deprecated in favor of Spree.deprecator.

[lauriejefferson]

@kennyadsl @jarednorman Can this PR be closed?

[tvdeyen]

@lauriejefferson would you mind to rebase and force push your branch with latest main to retrigger the pipepline? Thanks 🙏🏻

[lauriejefferson]

@tvdeyen Rebase completed.

[lauriejefferson]

@jarednorman @tvdeyen @kennyadsl Is there any feedback on this issue?

[jarednorman]

Nope, I have approved and am just waiting for another person on core to approve.

[tvdeyen]

@lauriejefferson the spec failures are related. Mind taking another look?

[lauriejefferson]

@tvdeyen I fixed the rspec tests. Please review.

[nvandoorn]

Hey @lauriejefferson, I have a revised version of this branch available here: https://github.com/nvandoorn/solidus/tree/4860-deprecate-and-remove-dashboards-code

The specs should pass and everything is up to date. You're welcome to pull these changes if you wish, or I can open another pull request.

[lauriejefferson]

@nvandoorn Has your branch been approved? I'm not sure if I need to pull your changes. I may have added what was necessary to complete this issue. @jarednorman @tvdeyen Please advise.

[nvandoorn]

Hey @lauriejefferson, I haven't opened a pull request yet so the changes have not been approved yet.

I believe the current revision of this pull request needs a revision for the specs to pass as indicated by @tvdeyen's last comment.