solidus icon indicating copy to clipboard operation
solidus copied to clipboard

WIP Extract legacy promotions

Open mamhoff opened this issue 5 months ago • 3 comments

Summary

This extracts the legacy promotion system into a gem that lives within the solidus codebase. I've talked about this with @kennyadsl as a way to integrate a new solidus_promotions gem later, modeled after solidus_friendly_promotions.

This is still Work in progress, and comments are welcome.

Checklist

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

mamhoff avatar Jan 27 '24 15:01 mamhoff

Codecov Report

Attention: Patch coverage is 97.56098% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 88.81%. Comparing base (d5dd8b6) to head (48f1a68).

:exclamation: Current head 48f1a68 differs from pull request most recent head 5bebaa5. Consider uploading reports for the commit 5bebaa5 to get more accurate results

Files Patch % Lines
...otions/migrations/promotions_with_code_handlers.rb 0.00% 3 Missing :warning:
...gacy_promotions/app/models/spree/order_contents.rb 95.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5634      +/-   ##
==========================================
- Coverage   88.87%   88.81%   -0.07%     
==========================================
  Files         699      705       +6     
  Lines       16607    16660      +53     
==========================================
+ Hits        14760    14797      +37     
- Misses       1847     1863      +16     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 27 '24 16:01 codecov[bot]

Depends on #5635

mamhoff avatar Jan 29 '24 16:01 mamhoff

Thanks for your work on this @mamhoff. Now to find time to actually review it properly... 😅

jarednorman avatar Jan 29 '24 19:01 jarednorman