solidus
solidus copied to clipboard
WIP Extract legacy promotions
Summary
This extracts the legacy promotion system into a gem that lives within the solidus codebase. I've talked about this with @kennyadsl as a way to integrate a new solidus_promotions gem later, modeled after solidus_friendly_promotions.
This is still Work in progress, and comments are welcome.
Checklist
The following are mandatory for all PRs:
- [ ] I have written a thorough PR description.
- [ ] I have kept my commits small and atomic.
- [ ] I have used clear, explanatory commit messages.
The following are not always needed:
Codecov Report
Attention: Patch coverage is 97.56098%
with 4 lines
in your changes are missing coverage. Please review.
Project coverage is 88.81%. Comparing base (
d5dd8b6
) to head (48f1a68
).
:exclamation: Current head 48f1a68 differs from pull request most recent head 5bebaa5. Consider uploading reports for the commit 5bebaa5 to get more accurate results
Files | Patch % | Lines |
---|---|---|
...otions/migrations/promotions_with_code_handlers.rb | 0.00% | 3 Missing :warning: |
...gacy_promotions/app/models/spree/order_contents.rb | 95.00% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #5634 +/- ##
==========================================
- Coverage 88.87% 88.81% -0.07%
==========================================
Files 699 705 +6
Lines 16607 16660 +53
==========================================
+ Hits 14760 14797 +37
- Misses 1847 1863 +16
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Depends on #5635
Thanks for your work on this @mamhoff. Now to find time to actually review it properly... 😅