solidus icon indicating copy to clipboard operation
solidus copied to clipboard

WIP Extract legacy promotions

Open mamhoff opened this issue 2 years ago • 3 comments

Summary

This extracts the legacy promotion system into a gem that lives within the solidus codebase. I've talked about this with @kennyadsl as a way to integrate a new solidus_promotions gem later, modeled after solidus_friendly_promotions.

This is still Work in progress, and comments are welcome.

Checklist

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

mamhoff avatar Jan 27 '24 15:01 mamhoff

Codecov Report

Attention: Patch coverage is 93.02326% with 6 lines in your changes missing coverage. Please review.

Project coverage is 88.94%. Comparing base (97f9f69) to head (a78e28d).

Files Patch % Lines
...otions/migrations/promotions_with_code_handlers.rb 0.00% 3 Missing :warning:
...s_legacy_promotions/testing_support/factory_bot.rb 76.92% 3 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5634      +/-   ##
==========================================
+ Coverage   88.92%   88.94%   +0.01%     
==========================================
  Files         719      724       +5     
  Lines       16944    16974      +30     
==========================================
+ Hits        15068    15097      +29     
- Misses       1876     1877       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 27 '24 16:01 codecov[bot]

Depends on #5635

mamhoff avatar Jan 29 '24 16:01 mamhoff

Thanks for your work on this @mamhoff. Now to find time to actually review it properly... 😅

jarednorman avatar Jan 29 '24 19:01 jarednorman

@kennyadsl are we ready to go?

tvdeyen avatar Jun 20 '24 15:06 tvdeyen