Jared Norman

Thank you! I understand now. I wasn't thinking about the implicit transaction when you have callbacks. I will have to look at how complex that behaviour would be to add...

I _think_ this is an enhancement, but one that should have been considered a breaking change and warranted a major version bump. I'm leaning towards keeping this behaviour, possibly testing...

I haven't yet had time to review this to determine if I'm happy with the solution. Feel free to use your the branch directly until I get time. This project...

Hmmm. I'm struggling to find a reference to when AR uses transactions automatically. If all persistence operations are run in a transaction and discard uses the public persistence API for...

I can whip up a PR to change the fingerprint detection from `/-([0-9a-f]{7,128})\.digested/` to something like `/-([0-9a-zA-Z]{7,128})\.digested/` if that's not too permissive. I know the original intent was to avoid...

Yep, that should resolve this!

If there's not documentation as to what those plans were and the functionality doesn't exist now, I don't think it's worth keeping.

We probably don't want https://github.com/solidusio/solidus/blob/master/core/app/models/concerns/spree/soft_deletable.rb to be code-reloaded. It sounds like there's an issue with code reload order with it.

If you put the keyword commit in a new PR we can merge it right away. I don't think the other commit will be the solution we want for the...

> @jarednorman if you removed all the references for acts_as_paranoid here https://github.com/solidusio/solidus_auth_devise/blob/master/app/models/spree/user.rb#L11=, why we continue using here https://github.com/solidusio/solidus_auth_devise/blob/master/app/models/spree/user.rb#L14=? for older Solidus versions is ok, but since 3.0 removed Paranoia, I...