Jared Norman comments

Results 162 comments of


                                            Jared Norman

Remove Spree::Order#add_default_payment_from_wallet checkout transition

This is related to #2680.

Remove Spree::Order#add_default_payment_from_wallet checkout transition

Thanks @danielpuglisi (and @adammathys), that would be great!

(doc/guides) Unclear how to monkey patch e.g. Address to not require_phone?

Sounds like the desired outcome of the original discussion here might be that [this guides page](https://guides.solidus.io/developers/customizations/decorators.html) might need to be updated to be clearer about naming convention requirements. Is that...

Admin panel - users - edit exist user - update address field always return 200

Looks like a bug that needs to be looked into by someone. Would appreciate any more information on this you found in debugging it. What version of Rails are you...

Make option value to variant association unique

I don't think any of the errors have anything to do with my change. 🤔

Make option value to variant association unique

Had to scroll back more. I used 6.2 as the migration version, but currently we have to write migrations for the lowest supported ActiveRecord version.

Shipping rates are destroyed after selecting a shipping method in admin

Yeah, it's a weird bit of the domain where I think most people think you're selecting a shipping method (which you'd then infer the rate from), despite that not being...

Prevent creation of customer returns when the order has no shipped inventory units

Yeah, I think this issue could use a rebrand as "Prevent creation of customer returns when the order has no shipped inventory units".

Some gateways want the gateway order_id to be consistent for transactions on the same order

We could make the gateway order ID logic configurable, or perhaps a more sensible thing could be to delegate to the gateway for it.

JQuery 1.12.4 (with vuln) loaded by default

Thanks for pointing this out!