Jared Norman
Jared Norman
I think we definitely have more valuable things to spend our time maintaining.
This is an interesting one. I'd expect the the product to show multiple times if it was included multiple times, and that the pagination would correctly handle that situation.
Honestly, upon review, I'm not sure what the desired behaviour is here. The initial issue outlines possibilities: > It's also not clear how products should be ordered on a taxon...
What's the use case for having a product in a taxon as well as one of its children?
As I understand it, this issue relates to the situation when you're displaying the products of a taxon and its children. Perhaps I'm missing something.
Agreed. I would like to see the admin powered by it's own endpoints, rather than this implicit dependency between the two components.
I'm sure in a few currencies it's conceivable.
This is presumably for caching reasons, but you're definitely right. We should probably be scaling back these kinds of things as for most stores they may want to have their...
Coincidentally, just realized we encountered this issue the other day. Didn't immediately occur to me what it was. Thanks for reporting!
Should we even be doing this in a transaction? Is this only happening because `touch_taxons` is happening in an `after_save`/`after_touch`? Could we switch to using `after_commit` instead, so that it's...