Jared Norman

Results 113 comments of Jared Norman
trafficstars

I think they should be deprecated first.

We have API documentation, but it's not complete. For example, if you wanted to see the document for the `Spree::Payment` class, you would look it up here: https://www.rubydoc.info/gems/solidus_core/3.2.3/Spree/Payment Is that...

I tend to think that making that in-code documentation (and thus the API docs) really good is a really high-leverage way to improve the Solidus documentation situation. The guides are...

I'm also getting this error, and it's caused by a specific one of my git repos, it seems. :cry:

No dot or any other weird characters. It's just of the format "fooBar".

Changing between git-log/git-standup has no effect on the error for me. The only thing that changes whether I get this error is whether I include this one repo I have...

Mysteriously just started working today. :confounded:

@mamhoff I don't think this will impact you then? You can still have multiple variants per option value, just not the the same option value on one variant multiple times.

> Currently the callbacks such as after_discard are run outside of the discarded model's transaction. Perhaps I don't understand the context where you're seeing this behaviour. There's not normally a...