jakecastelli

Results 97 comments of jakecastelli

I have raised this one in openjs flaky ci slack channel and @Qard has responded positively 🙏 I think he would take a look soon.

The reason you won't see the warning in `v21.7.3` but see in `v22.0.0` is because since `v22.0.0` it starts to detect unsettled top-level await - see this [commit](https://github.com/nodejs/node/commit/575ced8139#diff-ea501528b0419a0e268dba0a111869879926d671b7e4240a7f8177e9eb384a4bR125) - more...

For `test-runner-coverage.js` - When `NODE_V8_COVERAGE` is set the report will be written into the dest directory, currently for `test-runner-coverage.js` is set to `tmpdir.path` maybe what we need to do is...

Thanks Richard, you are right about this, when I commented out the test that has `NODE_V8_COVERAGE`, it still writes to the temp dir and not being cleaned up. I will...

I spent some time to further investigate and found out whether or not `NODE_V8_COVERAGE` is set or not, it will always write to the system temp dir and then if...

It is hard to clean those files after the tests - because the way we created them is using `mkdtempSync`. ```js const coverageDirectory = mkdtempSync(join(tmpdir(), 'node-coverage-')); ``` which is a...

I attempted to remove the tmp dir by doing this: ```diff } finally { if (dir) { dir.closeSync(); + rmSync(this.coverageDirectory, {__proto__: null, recursive: true }); } } } ``` in...

If you could try to `cd` into `$TMPDIR` and `rm -rf node-coverage-*` then you could add the patch into the `cleanup` function in `coverage.js` (make sure you import `rmSync` at...

Sorry for being annoying to add another quick note here, the whole reason I wanted to fix this issue is because each time we run the above test (`test-runner-coverage.js`) it...

I want to join this session, I am Australian Central Daylight Time, I don't have a preferred time will try my best to make it