jakecastelli
jakecastelli
Yes, looks unrelated, I have kicked started a rerun
> I don't think it should be supported. It is most likely a programmer error. I agree, but I am afraid this would break many user land packages.
I've been thinking about it, and I think we should more carefully consider whether we should throw directly in `pipe` method or not. The reasons being: * `Readable.from` will have...
Thank you for the review! 🙏 I appreciate the feedback and am happy to remove this error. As @ronag pointed out, it seems like I may have over-engineered it. My...
I'm still unsure about whether we should catch the error or proceed with a hard crash. Is there a similar example in Node.js core that we could use for comparison?...
Would be great to have some reviews, no hard feeling if folks would like to block it @nodejs/streams
Do you mind taking another quick look? @mcollina 🙏
Had some unrelated coverage failure on Windows, rebased and rerun everything
CI is green again, can I get another approval or can someone take another look (since I need to rebase to pass the GHA) 🙏
This PR is technically ready to land, would you mind taking another quick look on CITGM @mcollina Also need another approval since this PR needed a rebase