jakecastelli comments

Results 68 comments of


                                            jakecastelli

trafficstars

watch with test not picking up new test files

This is caused by `FileWatcher` being in the `filter` mode when you run `node --watch --test`, which means it finds all the test files at the start and store it...

watch with test not picking up new test files

Cheers mate, I've also found that rename, delete a watched test file would cause to throw an error #53113.

watch with test not picking up new test files

Sure! Let me know if you need a hand or something

watch with test not picking up new test files

@brettearle sure, I have reached you out.

watch with test not picking up new test files

I will take a look at your PR asap

watch with test not picking up new test files

Fixed by https://github.com/nodejs/node/pull/54225, thanks for the hard work @pmarchini 🚀

test_runner: handle file rename and deletion under watch mode

@MoLow I have added tests to cover both `rename` and `delete` a watched test file 👍 could you please take a look when you have time

test_runner: handle file rename and deletion under watch mode

Could someone help me to kick start the CI? 👀 Thanks!

test_runner: handle file rename and deletion under watch mode

Looks like there are a few failing jobs (most likely flaky tests 👀) I guess they need a rerun?

Strange behavior with `fs.watch` on file with JSON stringified -> first update isn't emitted if too fast after `fs.watch`

I dug a bit on this on and I think first of all this is a macOS related issue as it cannot reproduce on Linux. I think this its related...