jakecastelli

Results 68 comments of jakecastelli
trafficstars

To extend @jazelly's point - here is a small repo with `node:http` ```js // fetch-test.js import { createServer, request } from "node:http"; const port = 8084; const url = new...

one small nit - the https://github.com/nodejs/node/labels/commit-queue-squash label would squash all your commits and use the first one upon landing - the first commit message in this case is [test_runner: added...

Ahh no worries at all! Happy to do another approval / CI once the commit message is fixed 👍

This will need a rebase again 😞

Benchmark result https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1627/ 🟢 Results ``` confidence improvement accuracy (*) (**) (***) buffers/buffer-atob.js n=1000000 size=128 0.06 % ±0.50% ±0.66% ±0.86% buffers/buffer-atob.js n=1000000 size=16 0.77 % ±1.03% ±1.37% ±1.79% buffers/buffer-atob.js n=1000000...

> AssertionError [ERR_ASSERTION]: ifError got unwanted exception: ENOSPC: no space left on device, write 😞 should I cc build team?

CI got stuck for 6 hours, cancelled and rerunning now

`parallel/test-async-context-frame` happened to be quite flaky - https://github.com/nodejs/reliability/blob/main/reports/2024-09-05.md#jstest-failure

Artifacts were being cleared up due to space issue on jenkins, restart again 😞

my patient finally paid off 😆