jakecastelli

Results 68 comments of jakecastelli
trafficstars

Some update: Been running this test on a Linux ubuntu x64 machine, more than 100k+ runs, no failure. But running on my m1 arm64 will have a quite consistent 0.1%...

Marked as flaky in 53751, hopefully we can find what the root cause is.

Green CI now 🥳 would appreciate someone can take a look again and give a green tick so this PR is able to land (my latest change was skipping the...

@mcollina do you mind taking a quick look 🙏 as you recently did some work in this area as well

Hi @ehmicky, I had a look at your implementation and realised you took the effort to make it work with both node `18` and `20`, I think if this is...

what environment did you guys reproduce it locally? @aduh95 @fahrradflucht

Good work on pushing the progress! (Just a thought - I think the origin author might deserve a co-author in the commit message? As the change looks quite identical).

Thanks for bringing this up, I realised this bug as well, and I forgot to create an issue for it 😄

will start CI again as soon as [this](https://github.com/nodejs/node/pull/54332) PR lands (just make sure there are no false positive test results) thanks for your patient 🙏

Would you mind rebasing 😄 so I can kick start the CI again 👍