jakecastelli

I have run the benchmark for `async_hooks` and `events`, here are the results: events: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1616/ async_hooks: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1615/ Does not look like this change would cause any performance regression. But would...

@joyeecheung @targos @benjamingr PTAL 🙏

> a test would be nice Thinking about this again, maybe we should add a test to the `test/known_issues` and put refs on the top. In this way, folks who...

Do you have any objections on this one? @joyeecheung @legendecas 👀

Thanks for reviewing, I agree with you. Since this is rarely going to happen and the recovery is not costly (either revert or fast track a fix), I think it...

> Instead, I think we should look into using GitHub's commit queue system (which I think can ensure that tests pass after applying the commits in order). That's not a...

> The main problem is how slow and flaky our CI has been A full CI run would be rough, but a quick test run (on windows, macOS, Linux) hopefully...

Thanks for summarising the concerns and feedback @aduh95, I have decided not to proceed with landing, I left it open for a bit just to see if there were other...