Jack O'Quin

Results 158 comments of Jack O'Quin

I'd be grateful if you'd copy the indentation style of the rest of the file, when making modifications. No particular style is better than any other, but consistency is good...

If I remember correctly, the reason is that the Image message gets passed to ROS on the `publish()` call, which takes ownership the message. After that, the driver is not...

Since your problem goes away when you use the new Indigo release package, I suppose this issue can be closed now.

Unfortunately, there is still no documentation for the relatively new triggering support. You still have to read the relevant commits to figure out what to do. See: #19

@mhkabir: thanks for the report, please forgive the slow response. I have trouble testing hardware triggering with the test cameras I have available. So, your experience should be helpful. What...

Right now, the minimum set of parameters I can discover for S/W triggering is: ``` ``` From an external user perspective, that seems somewhat redundant and confusing. - Should setting...

I suppose `~auto_trigger` reflects different states of the camera hardware: - Off: the camera supports triggering with separate power control for that feature, and it is currently powered off. -...

From the way it's used, "external" triggering does not necessarily imply "hardware". It seems to mean triggering from some clock source external to the camera, either H/W or S/W. Is...

The minimum for S/W triggering on my Sony camera seems to be what I listed above. That raises the question: why have the `~software_trigger` parameter? Isn't it equivalent to `~external_trigger:...

We need to expose trigger source software in the configuration API, for unit test purposes. We only need to tell users that a polled_camera interface is planned (#13) for future...