iwubcode

Results 203 comments of iwubcode

I think I originally gave you the instruction to put your resources in the "Load" folder. However, I wasn't remembering correctly from my reference implementation (editor PR). I'd like to...

This means other features will not receive those events as well (they will get 2 events, instead of the number of frame skips that were triggered). I'd prefer to have...

> In regards to your work, this only affects holding the Frame Advance button and not custom Frame Advance logic. My work was the first thing I thought of. Not...

Believe fixed by https://github.com/dolphin-emu/dolphin/pull/13311

Unfortunate that Qt's variant doesn't have a `ToStringView`

Code wise it makes sense to me but we have others that maybe are better equipped to review it. Functionally I didn't test it because I struggle seeing this sort...

Assuming I haven't reduced the performance benefits with GM2.0 then this is probably another one for #12156 when I can get back to it.. (adding to remind myself).

I looked into this years ago. I imagine there are cases where our pixel center correction rounds incorrectly. Even in the fifoci you can see a case ([nhl-slap](https://fifo.ci/compare/12546499-12538639/)) where we...