RetroAchievements - Default Badges

[LillyJadeKatrin]

This PR adds the infrastructure to use default Achievements-related badges/icons located in the Sys folder when badges normally downloaded from the RetroAchievements website are unavailable. The badges provided here are placeholders for when a graphics designer within Dolphin can provide better replacements.

[iwubcode]

I think I originally gave you the instruction to put your resources in the "Load" folder. However, I wasn't remembering correctly from my reference implementation (editor PR). I'd like to keep the Load folder rather clean. As to me that folder should mirror the "User/Load" folder and refers to loaded content that Dolphin team maintains.

Not sure if we need another folder ("resources"?) to keep the root from getting too chaotic.

EDIT: Oh we have a resources folder already. Maybe we just need better organization under that.

[LillyJadeKatrin]

I think I originally gave you the instruction to put your resources in the "Load" folder. However, I wasn't remembering correctly from my reference implementation (editor PR). I'd like to keep the Load folder rather clean. As to me that folder should mirror the "User/Load" folder and refers to loaded content that Dolphin team maintains.

Not sure if we need another folder ("resources"?) to keep the root from getting too chaotic.

EDIT: Oh we have a resources folder already. Maybe we just need better organization under that.

Instructions unclear, moved files to Licenses folder :p

Kidding, but where should I put these? Resources/RetroAchievements?

[mbc07]

I'd just drop them under Sys\Resources, without a subfolder. The existing ones aren't separated anyway, and this can be handled in a later PR if it bothers enough...

[MayImilae]

Is there anything else needed to merge this? I'm already working on the permanent badges, and this will need to be merged before I can make a PR with those.

@iwubcode Please review!

[AdmiralCurtiss]

I swear someone else pointed this out but I don't see it... but the trophy and trophy_color icons should be called something like trophy_locked and trophy_unlocked instead.

Also, shouldn't they be achievement rather than trophy? Trophy is Sony terminology.

[MayImilae]

The current plan as I discussed with Lilly is for them to be padlocks, so that will change. But I could delete the trophies in the upcoming PR with the new icons. Depends on what Lilly wants to do.

[AdmiralCurtiss]

The current plan as I discussed with Lilly is for them to be padlocks, so that will change. But I could delete the trophies in the upcoming PR with the new icons. Depends on what Lilly wants to do.

The point is that currently one would need to update the code when the contents of the images changes, since the filenames refer to a specific object rather than a generic concept.

[mbc07]

I swear someone else pointed this out but I don't see it...

It was me, but I commented on Discord. I'll leave the message here too, for reference:

achievements_player.png and achievements_game.png closely resembles the const names used in code (DEFAULT_PLAYER_BADGE_FILENAME and DEFAULT_GAME_BADGE_FILENAME), but achievements_trophy.png and achievements_trophy_color.png do not

In the previous PR regarding the default badges (from before the rc_client refactor), May pointed out Dolphin assets doesn't use color to represent different states, so with that in mind, I'd suggest updating the placeholder trophy filenames to achievements_locked.png and achievements_unlocked.png, respectively.