Mark Mandel

Results 953 comments of Mark Mandel

Interesting. Not something I've ever had a need of - out of curiosity, what is the use case?

So unless I'm mistaken, this is a breaking change? As it changes `colddoc:abstract` -> `colddoc_abstract`, which would break other people's documentation. Would that be correct?

Unless you want to write a way to switch it out - or better yet - support either option

Sorry - didn't mean to close it.

Looks good. I'll do a local merge and run it through the test suite, and should be good to go.

This might be a docsy issue? Maybe one they have already solved? 🤔

Caught by `TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_true` in e2e-stable again. ``` me="2022-08-08 20:43:40.271" level=info msg="waiting for fleet condition" fleet=simple-fleet-1.0f7sz9 test="TestFleetRollingUpdate/Use_fleet_Patch_false_10%_cycle_false" panic: Fail in goroutine after TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_true has completed goroutine 1792 [running]: testing.(*common).Fail(0xc000901a00) /usr/local/go/src/testing/testing.go:710 +0x1b4...

Gentle bump on review @roberthbailey 😄

Wheee! Lots of work! A couple of questions before I dig into in detail. 1. Did you regenerate the grpc server and client code with `make gen-sdk-grpc` - I figured...