Mark Mandel

So as a general statement: We're post 1.0, so our API should be stable, and not break. If have to, we should have a deprecation period with plenty of time...

> This is because I changed rest api test only one line. The following line. From memory, the REST client generated from the swagger spec on each test: https://github.com/googleforgames/agones/blob/main/build/build-sdk-images/restapi/build-sdk-test.sh Because...

The good news is - we have e2e tests for the allocation REST endpoints (although now I'm curious how they didn't fail 🤔 ) https://github.com/googleforgames/agones/blob/9ba7a355245a20efb8a4e27a78f63a8047dabd6a/test/e2e/allocator_test.go#L249 https://github.com/googleforgames/agones/blob/9ba7a355245a20efb8a4e27a78f63a8047dabd6a/test/e2e/allocator_test.go#L313 So we know that...

Just wanted to gently bump this, see where things had landed 😄

I just realised something for doing testing to make sure the SDK Rest API is the same 😄 that I think will actually be relatively straightforward d to test with....

No worries - it's a big chunk of work, just wanted to touch base and see where things where at.

This sounds very reasonable. > What you expected to happen: Once a fleet is deleted, agones should keep it in the metrics endpoint long enough for it to be scraped...

SGTM.

Making a note that while we are in here, we should do the same thing for FleetAutoscalers as well (since it's all together).

I've got a POC working for Fleets (I basically have to unregister then register the entire `View` to reset it's values and then rebuild it after a Fleet gets deleted...