Tim Meusel

Hey, thanks for the contribution! Can you please rebase? That will enable the acceptance tests.

@tskirvin we cannot merge this due to the merge conflict. You can checkout the branch, solve the conflicts and submit it as a new PR.

there is an explicit test for the old behaviour, I wam wondering if this was implemented on purpose, but I dont see a reason for it 🤔

I'm still :+1: for deprecating it. Personally I've no interest in maintaining it since I use theforeman/puppet. Also it seems like nobody else want's to work on it.

@ekohl I agree to 100%. I dont see a purpose in maintaining it.

Hi @fondemen, are you able to add some spec tests to validate this?

Thanks for the PR @runejuhl. Can you please add some tests for the datatypes?

Hi @vchepkov, thanks for the PR. Can you add spec tests for your change? Join us in our IRC channel #voxpupuli on freenode if you've any questions about testing.

I agree with @ekohl. @coder-hugo can you please take a look at the suggestions?

Hi @netdata-be, thanks for the PR. Can you please rebase and take a look at the failing travis tests?