puppet-gluster icon indicating copy to clipboard operation
puppet-gluster copied to clipboard

Published 20 hours ago • verified publisher icon voxpupuli

pass 'release' attribute to sub classes

Open vchepkov opened this issue 8 years ago • 4 comments

prior to this this commit 'release' atribute from 'main' class wasn't passed to sub-classes construct '! defined Class' provides random results, parser dependable and shouldn't be used

vchepkov avatar Mar 30 '17 14:03 vchepkov

Hi @vchepkov, thanks for the PR. Can you add spec tests for your change? Join us in our IRC channel #voxpupuli on freenode if you've any questions about testing.

bastelfreak avatar Apr 03 '17 21:04 bastelfreak

I am pretty much inept, when it comes to tests, if you point me to an example, I can try to make something up, but in my defense, it seems tests didn't much helped here, 'release' attribute to the class wasn't used anywhere

vchepkov avatar Apr 04 '17 23:04 vchepkov

Dear @vchepkov, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

vox-pupuli-tasks[bot] avatar Jan 05 '20 13:01 vox-pupuli-tasks[bot]

Dear @vchepkov, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

vox-pupuli-tasks[bot] avatar Jan 05 '20 18:01 vox-pupuli-tasks[bot]