puppet-gluster icon indicating copy to clipboard operation
puppet-gluster copied to clipboard

Published 20 hours ago • verified publisher icon voxpupuli

Fix unnecessarily setting gluster volume option repeatedly

Open runejuhl opened this issue 6 years ago • 8 comments

Checks Gluster volume options against existing values to avoid repeatedly setting values.

Also adds these types:

  • Gluster::VolumeName
  • Gluster::VolumeOption

And these functions:

  • gluster::cmd_volume_get_option
  • gluster::onoff

runejuhl avatar May 24 '19 11:05 runejuhl

Thanks for the PR @runejuhl. Can you please add some tests for the datatypes?

bastelfreak avatar May 29 '19 20:05 bastelfreak

You're welcome @bastelfreak -- I've pushed some improvements.

I'll be in front of a gluster cluster on Monday, I'll test it then and add some tests for the datatypes.

runejuhl avatar May 29 '19 20:05 runejuhl

Dear @runejuhl, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

vox-pupuli-tasks[bot] avatar Jan 05 '20 13:01 vox-pupuli-tasks[bot]

Dear @runejuhl, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

vox-pupuli-tasks[bot] avatar Jan 05 '20 18:01 vox-pupuli-tasks[bot]

Dear @runejuhl, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

vox-pupuli-tasks[bot] avatar Jan 05 '20 18:01 vox-pupuli-tasks[bot]

Fixed the merge conflict, still need to add tests as requested in https://github.com/voxpupuli/puppet-gluster/pull/196#issuecomment-497092987

runejuhl avatar Jan 06 '20 11:01 runejuhl

Dear @runejuhl, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

vox-pupuli-tasks[bot] avatar Mar 04 '20 08:03 vox-pupuli-tasks[bot]

Dear @runejuhl, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

vox-pupuli-tasks[bot] avatar Sep 30 '20 22:09 vox-pupuli-tasks[bot]